Skip to content

Add ST MB1835 MIPI DSI display shield #94423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

Add ST MB1835 MIPI DSI display shield #94423

merged 1 commit into from
Oct 21, 2025

Conversation

@CharlesDias
Copy link
Contributor

@CharlesDias CharlesDias commented Aug 12, 2025 •
edited
Loading

This PR adds display support for the ST MB1835 2.47-inch round DSI TFT-LCD daughter board designed for STM32 Discovery kits.

Tested with:
west build -p -b stm32u5g9j_dk1 --shield st_lcd_dsi_mb1835 samples/drivers/display/
And also
west build -p -b stm32u5g9j_dk1 --shield st_lcd_dsi_mb1835 samples/modules/lvgl/demos -- -DCONFIG_LV_Z_DEMO_MUSIC=y

Features Enabled

  • 2-lane MIPI DSI interface
  • LTDC controller with ARGB8888 support
  • HX8379C panel driver integration
  • Display sample application support

Depends on:

@CharlesDias CharlesDias mentioned this pull request Aug 12, 2025
Merged
JarmouniA
JarmouniA reviewed Aug 12, 2025
View reviewed changes
@CharlesDias CharlesDias mentioned this pull request Aug 13, 2025
Merged
@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from 56f9346 to 9f5734e Compare August 13, 2025 19:06
@erwango erwango linked an issue Aug 19, 2025 that may be closed by this pull request
Need help to add mb1835b DSI display for board stm32u5a9j_dk and Introduce STM32U5 DSI host driver #71790
Open
@erwango erwango removed a link to an issue Aug 19, 2025
Need help to add mb1835b DSI display for board stm32u5a9j_dk and Introduce STM32U5 DSI host driver #71790
Open
@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch 2 times, most recently from da99dda to 96bc93e Compare August 19, 2025 18:55
@CharlesDias CharlesDias changed the title Add Display Support for STM32U5G9J-DK1 Board Add ST MB1835 MIPI DSI display shield Aug 19, 2025
@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from 96bc93e to 2ac0ef3 Compare August 20, 2025 07:11
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from 2ac0ef3 to 37d1dae Compare October 16, 2025 14:44
@CharlesDias
Copy link
Contributor Author

Rebase

@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch 2 times, most recently from 4045dae to 1d6105b Compare October 16, 2025 22:32
@CharlesDias CharlesDias marked this pull request as ready for review October 16, 2025 23:47
@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from 1d6105b to 8891c6d Compare October 17, 2025 19:34
@CharlesDias
Copy link
Contributor Author

Rebase

@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from 8891c6d to a586449 Compare October 17, 2025 19:41
JarmouniA
JarmouniA reviewed Oct 17, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the shield to st_lcd_dsi_mb1835, to be consistent with
https://github.com/zephyrproject-rtos/zephyr/tree/main/boards/shields/st_b_lcd40_dsi1_mb1166
Also, we should probably specify in the doc which shield revision is used for this port.

@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from a586449 to cad231f Compare October 17, 2025 20:59
@JarmouniA JarmouniA added this to the v4.3.0 milestone Oct 17, 2025
JarmouniA
JarmouniA previously approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@CharlesDias
Copy link
Contributor Author

Can we rename the shield to st_lcd_dsi_mb1835, to be consistent with
https://github.com/zephyrproject-rtos/zephyr/tree/main/boards/shields/st_b_lcd40_dsi1_mb1166
Also, we should probably specify which shield revision is used for this port.

Hi @JarmouniA. Thanks for your review!

I updated the shield name as suggested. How can I find out the version, and when did you recommend adding this information? Thanks for your guidance!

@JarmouniA
Copy link
Contributor

JarmouniA commented Oct 17, 2025 •
edited
Loading

How can I find out the version

The revision should be on the shield itself, and it is in the schematic file as well, revision B-01.

and when did you recommend adding this information?

It's just a nit really, in case the shield is updated but with a different controller (as is the case for mb1166 for ex.)

@CharlesDias
Copy link
Contributor Author

The revision should be on the shield itself, and it is in the schematic file as well, revision B-01.
It's just a nit really, in case the shield is updated but with a different controller (as is the case for mb1166 for ex.)

Could it be `st_lcd_dsi_mb1835_b01.overlay?

@JarmouniA
Copy link
Contributor

The revision should be on the shield itself, and it is in the schematic file as well, revision B-01.
It's just a nit really, in case the shield is updated but with a different controller (as is the case for mb1166 for ex.)

Could it be `st_lcd_dsi_mb1835_b01.overlay?

Ah sorry for the misunderstanding, I meant just somewhere in the shield doc.

@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from cad231f to ec3cb7c Compare October 17, 2025 21:32
JarmouniA
JarmouniA requested changes Oct 17, 2025
View reviewed changes
@CharlesDias
boards: shields: add ST MB1835 shield
91c16d0 
Add support for the ST MB1835 2.47-inch round DSI TFT-LCD daughter board
designed for STM32 Discovery kits.

Signed-off-by: Charles Dias <[email protected]>
@CharlesDias CharlesDias force-pushed the display_stm32u5g9j_dk1 branch from ec3cb7c to 91c16d0 Compare October 17, 2025 21:41
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jhedberg jhedberg merged commit 49261a7 into zephyrproject-rtos:main Oct 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@JarmouniA JarmouniA JarmouniA approved these changes

@avisconti avisconti Awaiting requested review from avisconti

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@kartben kartben Awaiting requested review from kartben

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@VynDragon VynDragon Awaiting requested review from VynDragon

Assignees

@kartben kartben

Labels

area: Boards/SoCs area: Display area: Samples Samples area: Shields Shields (add-on boards) platform: STM32 ST Micro STM32

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@CharlesDias @JarmouniA @kartben @erwango @jhedberg @zephyrbot